Windows support #39
Merged
Windows support #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! I'll take a closer look hopefully tomorrow. |
jesseshieh
reviewed
Jul 18, 2019
|
Thanks for taking the time to code review/merge the change! I'm sure Windows support was low on your priority list so I appreciate it! It'll make my workflow a lot easier. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for #28.
Based on the hint you had in that issue I was able to figure it out. Windows thinks .netrc is a file extension so the common solution is to use a _netrc file instead. I also had to add the HOME environment variable since it's not normally set on Windows.
Something I had to do to get it to build was to comment out the git imports since it couldn't find the library. Not sure what I was doing wrong there though. I'm a complete amateur at Python.